Skip to content

Commit

Permalink
Add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
@hkjorgensen
hkjorgensen committed Jan 24, 2014
1 parent f6e9701 commit 6b9c34a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/grunt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if ('completion' in options) {
completion.print(options.completion);
} else if (options.version) {
info.version();
} else if (options.gruntfile) {
} else if (options.gruntfile) { //Note: if both `gruntfile` and `base` are set, use `gruntfile`
basedir = path.resolve(path.dirname(options.gruntfile));
} else if (options.base) {
basedir = path.resolve(options.base);
Expand Down

3 comments on commit 6b9c34a

@AndruC
Copy link

@AndruC AndruC commented on 6b9c34a Feb 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this has to be the case? It seems to me that if both base and gruntfile options are explicitly set, then base should be what it is specified as, rather than ignored.

@tkellen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this discussion:
gulpjs/liftoff#5

@ams-tschoening
Copy link

@ams-tschoening ams-tschoening commented on 6b9c34a Apr 4, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read that discussion, but don't understand your comment: Are you argueing pro or con the current behviour of ignoring base? Maybe I'm missing something, but your implemented approach of recognizing --cwd and --configfile is the opposite of what is currently implemented here and is the much better/flexible approach and what I would need myself currently as well.

Please sign in to comment.