Fix StripBanners option for concat #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StripBanners now work when passing in object (e.g. {block: true, line:
true}).
|
@ineedfat could you update your PR to pass the existing tests? |
|
ping, also need to fix the merge conflict. |
|
What do you guys think about using uncommentify instead of regexp? I've outlined the differences from the current implementation in this comment: #2 (comment) /cc @cowboy |
|
Closing due to no response |
|
I don't understand if this is fixed or not, because it doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StripBanners now work when passing in object (e.g. {block: true, line:
true}).