Skip to content

Fix StripBanners option for concat #16

Closed
wants to merge 1 commit into from

6 participants

@ineedfat
ineedfat commented Mar 6, 2013

StripBanners now work when passing in object (e.g. {block: true, line:
true}).

@ineedfat ineedfat Fix StripBanners Option
StripBanners now work when passing in object (e.g. {block: true, line:
true}).
aabb465
@GilbertSun

already using === , so 'typeof' is not necessary

@vladikoff
grunt member

@ineedfat could you update your PR to pass the existing tests?

@sindresorhus
grunt member

ping, also need to fix the merge conflict.

@shama
grunt member
shama commented Dec 12, 2013

What do you guys think about using uncommentify instead of regexp? I've outlined the differences from the current implementation in this comment: #2 (comment)

/cc @cowboy

@vladikoff
grunt member

Closing due to no response

@vladikoff vladikoff closed this Feb 2, 2014
@dcdeiv
dcdeiv commented Feb 20, 2016

I don't understand if this is fixed or not, because it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.