Fixed: options.open.{appName, callback} #230
Conversation
|
@vladikoff could you kindly take a look? |
|
Good stuff 👍 Would like to see this merged as A suggestion for this PR: is it worth updating the readme to point to opn instead of open? Also, |
|
This needs a rebase, no unrelated style changes and no unrelated version changes. |
bitnot
force-pushed
the
master
branch
2 times, most recently
from
ea213f8
to
78b4c20
Compare
|
Thanks for looking into this @XhmikosR! |
|
@bitnot: no you shouldn't update any meta files, this is done when a new release is made. |
docs/connect-options.md
Outdated
| @@ -82,6 +82,7 @@ This can be one of the following: | |||
| callback: function() {} // called when the app has opened | |||
| } | |||
| ``` | |||
| Note that in [v0.9.0](https://github.com/gruntjs/grunt-contrib-connect/releases/tag/v0.9.0) [open](https://www.npmjs.com/package/open) was replaced with [opn](https://www.npmjs.com/package/opn) but the configuration remained the same for backwards compatibility. `targed`, `appName` and `callback` are the only supported keys in the config object. | |||
There was a problem hiding this comment.
targed is this correct or it is a typo?
There was a problem hiding this comment.
Oh, thanks again! Fixed.
Passing `open.appName` config property to `opn` and calling `open.callback`.
|
@bitnot: can you skip README.md inclusion? We usually update it when we make the release. |
|
@XhmikosR |
|
Will be in v2.0.0 when that is made. Maybe you could add a test? |
|
I am not very good with node, but I will try to add a test. Any release date in mind? |
|
It doesn't depend on me otherwise I'd made the release already. I don't have access to this npm package, so when #252 is merged. |
Fixes #229 by passing open:appName config property to opn and calling open:callback.