Replace node-http2 with http2-wrapper
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vladikoff Could you please review this? |
|
@Krinkle Could you please help with merging this PR? |
|
@XhmikosR Could you please help here? |
|
/CC @vladikoff |
|
It seems this breaks CI tests FYI @vladikoff |
|
@XhmikosR Forked from here and fixed tests |
|
@XhmikosR I've fixed the broken test. |
|
LGTM now. But even if I merge it I don't have npm rights, so @vladikoff needs to take care of this. |
|
Sorry for the delay, I was sick and just getting back into the swing of things |
|
@vladikoff thanks for answering! could you please publish it to npm so we could use fixed package? |
|
@vavsab Hi, yeap done! |
|
@XhmikosR I added you to npm maintainers also 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the deprecated
node-http2dependency withhttp2-wrapper. It also removes checks related to0.xversions of Node.js, since they are already unsupported.Fixes #270.