Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a force flag to options to not exit on errors found. #15

Closed
wants to merge 4 commits into from
Closed

Adding a force flag to options to not exit on errors found. #15

wants to merge 4 commits into from

Conversation

belshire
Copy link

Adding a force flag to not fail the task but still report when errors and warnings are found. Inspiration came from the implementation in the jshint grunt task

@nschonni
Copy link
Contributor

Probably good to add an example in the README because I think this is a common scenario due to a few outstanding bugs in parser-lib (IE CSS expressions, @document support, etc...)

@belshire
Copy link
Author

Added documentation on usage for the force flag to the README and the individual .md files in the docs folder.

@nschonni
Copy link
Contributor

@shama any objections to this?

@shama
Copy link
Member

shama commented Jul 26, 2013

I spoke with @cowboy today in IRC about whether tasks should fail or warn on error. He said warn on errors. So pretty soon I'll go through the tasks and make that consistent (as I know some do fail on errors and some don't).

In which case we shouldn't need a force option implemented here or within the other tasks anymore.

/cc @tkellen @sindresorhus @jsoverson

I appreciate you putting together this PR though @belshire! and thanks for reviewing @nschonni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants