Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options.amd as a function #119

Merged
merged 1 commit into from Apr 21, 2015
Merged

Conversation

alexindigo
Copy link
Contributor

Allows greater flexibility for building subtemplates dependencies, current implementation allows only static list on the config. With this change dependency list could be built per template from AST or compiled code.

Thank you.

CLA's signed

@alexindigo
Copy link
Contributor Author

@tkellen @vladikoff @jmeas @sindresorhus anything else you'd like for me to do to move this PR forward? Thank you.

@vladikoff vladikoff self-assigned this Nov 11, 2014
@stephanebachelier
Copy link
Contributor

@alexindigo Could you add some documentation in the README ?

https://github.com/gruntjs/grunt-contrib-handlebars#amd

@sindresorhus
Copy link
Member

👍 docs/options.md needs to be updated and merge conflict fixed.

@vladikoff
Copy link
Member

Yeap!

docs/options.md needs to be updated and merge conflict fixed.

@vladikoff vladikoff removed their assignment Apr 7, 2015
@alexindigo
Copy link
Contributor Author

@vladikoff @sindresorhus @stephanebachelier Updated docs and resolved conflicts.
Thank you.

@ingiulio
Copy link

👍

vladikoff added a commit that referenced this pull request Apr 21, 2015
Added options.amd as a function
@vladikoff vladikoff merged commit 900b5a7 into gruntjs:master Apr 21, 2015
@vladikoff
Copy link
Member

Excellent, thank you!

@alexindigo
Copy link
Contributor Author

Thank you.

@alexindigo
Copy link
Contributor Author

@vladikoff Can we create couple more versions with this change? 0.8.1 for handlebars 1.3 and 0.9.4 for handlebars 2.0, some third libraries depend on older version of handlebars and can't use 0.10.x. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants