Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in logSummary() #220

Merged
merged 2 commits into from
Aug 4, 2015
Merged

Conversation

michaelhogg
Copy link
Contributor

With options.summary set to true, this fatal error occurs:

Summary (1 tests failed)
Fatal error: Cannot read property 'display' of undefined

This bug was introduced in commit f5ac86e ("Assorted lint fixes") on 23 April 2015. The first affected version is v0.9.0.

This bug was introduced in commit f5ac86e ("Assorted lint fixes")
@vladikoff
Copy link
Member

@michaelhogg

Running "jshint:all" (jshint) task
   tasks/jasmine.js
    381 |            grunt.log.writeln(chalk.red(symbols[options.display]['error']) + ' ' + test.suite + ' ' + test.name);
                                                                         ^ ['error'] is better written in dot notation.
>> 1 error in 6 files
Warning: Task "jshint:all" failed.� Use --force to continue.

This needs to be adjusted to support your patch

@michaelhogg
Copy link
Contributor Author

Done 👍

vladikoff added a commit that referenced this pull request Aug 4, 2015
@vladikoff vladikoff merged commit 36760b0 into gruntjs:master Aug 4, 2015
@xGouley
Copy link

xGouley commented Aug 5, 2015

Just the same bug as I reported few weeks ago, with the same fix proposal, and a PR made 5 days ago... (https://github.com/gruntjs/grunt-contrib-jasmine/pull/219/files)
Thank you anyway to applied the fix, finally. So you can close my PR and my issue (#217).

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants