Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added --allow-file-access-from-files tag issue 298 #306

Merged
merged 1 commit into from
Jun 6, 2019
Merged

added --allow-file-access-from-files tag issue 298 #306

merged 1 commit into from
Jun 6, 2019

Conversation

vatsala-glory
Copy link
Contributor

No description provided.

@vatsala-glory vatsala-glory mentioned this pull request Jun 6, 2019
Closed
@steveoh steveoh merged commit f9b99fd into gruntjs:master Jun 6, 2019
@jabbany
Copy link
Contributor

jabbany commented Jun 11, 2019 •
edited

Given this and the --no-sandbox bit of code before it, it might have been easier and more future-proof to just let a user pass in a custom sandboxArgs array for the sandbox (puppeteer) initialization...

@steveoh
Copy link
Contributor

steveoh commented Jun 11, 2019 •
edited

@jabbany that's a solid idea.

tracking it in #307

@showuon showuon mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveoh steveoh steveoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vatsala-glory @jabbany @steveoh