-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test does not run via grunt/phantom, but OK in web browser #19
Comments
Any progress with this issue? I've come across it for my build processes, though downgrading to 2.0.6 does work. |
Bah.... I was pulling my hair why the f### it was not working. |
Is there any progress on this? It's been a while since anything. I have downgraded and it works, but seems like a larger workaround. |
@frederickf in this comment may have found something about the test setup that may be important, you might try that to see if it fixes the issue for you: If it does fix the issue, please leave a comment back here and then maybe we can close this issue. |
Is this related to this issue #35 where qunit needs to not start until everything is loaded? |
@jrburke @shama just tried to fix my problem using #35 as an example, and it works correctly. Thanks for the help. All I had to do was put Works perfect, and now I don't have to have multiple versions of require lying around |
Changed: Prevent automatic start of tests and start them manually after requirejs was loaded and executed. This way tests are picked up and run fine. Solves problem gruntjs/grunt-contrib-qunit#19
I believe I am seeing something a little different. I've got a plugin that is converting decimals to the equivalent fraction. While trying to convert it to a grunt project It almost looks to me like the tests via grunt round differently then in the browser? |
sounds to be related to phantomjs. Did you report there ? With some reproducible examples. |
I did not but I'll give that a whirl. Thanks. Update(3/20/2014): Update:(3/21) |
Update and clean up README.
Found this related to the issue. http://stackoverflow.com/questions/18392463/grunt-not-running-qunit-tests-on-phantom Is there a solution yet? |
I've run into this issue for every requirejs-based grunt-contrib-qunit test I have, in several different projects. Doesn't affect tests that don't use require.js. Suspect it is realted this change: db075a2 |
Going to close this out, as @jzaefferer already pointed (#19 (comment)) to an example of using for a similar solution, see http://stackoverflow.com/a/34928952/3904791 |
OS 10.8.2, using phantomjs 1.8.1 and grunt v0.3.17:
This was originally filed as requirejs/requirejs#618. I am filing a ticket here because the require-2.1.4.js version of the test runs fine in QUnit in the browser, just opening test/index.html in a web browser.
While I am open to this being an issue with requirejs, my first thought is it may be due to how the qunit grunt task binds to the running qunit tests and how it detects with QUnit is "done".
One guess at the problem may be that requirejs 2.1.4 waits a bit longer to start the actual qunit test, after whatever signal the grunt qunit driver uses to detect "done".
So, any insight into what I might look at in the grunt qunit code, or pointers is appreciated.
The text was updated successfully, but these errors were encountered: