Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append the nib path to the paths option by default. #4

Closed
sebv opened this issue Nov 9, 2012 · 7 comments
Closed

Append the nib path to the paths option by default. #4

sebv opened this issue Nov 9, 2012 · 7 comments

Comments

@sebv
Copy link

sebv commented Nov 9, 2012

Just a suggestion, so that @import 'nib' works out of the box. Otherwise you have to specify a path to the grunt-contrib-stylus node_modules dir in your grunt file, which is not very intuitive.

@ctalkington
Copy link
Member

hum I've never had an issue. do u have custom paths set? can you provide example config?

@sebv
Copy link
Author

sebv commented Nov 9, 2012

My config is the one in the yeoman wiki, just wrote it today:

https://github.com/yeoman/yeoman/wiki/Stylus-integration
https://gist.github.com/ffcbf037e6e856e1010d

Edit: Am trying to avoid having to do: paths: ['node_modules/grunt-contrib-stylus/node_modules']

@ctalkington
Copy link
Member

hum you really shouldnt need to define that path. should work out of the box.

@sebv
Copy link
Author

sebv commented Nov 9, 2012

Actually it's a bit more complex than first thought:

This works:

stylus: {
  compile: {
    options: {
      compress: true
    },
    files: {
      'app/styles/*.css': ['app/styles/*.styl']
    }
  }
},

But if you add paths:[] or paths:['abc'] then Stylus doesn't find Nib anymore.

@ctalkington
Copy link
Member

ah, thats makes a little more sense. ill have to put together a test to see if we maybe auto add module path to paths.

@sebv
Copy link
Author

sebv commented Nov 9, 2012

Just tried to add @import 'nib' at the beginning of test/fixtures/stylus.styl and it crashes the same, so it is easy to reproduce.

@tkellen
Copy link
Member

tkellen commented Dec 7, 2012

Fixed in ab63002

@tkellen tkellen closed this as completed Dec 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants