Devel fix some problems #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ayumu! Are you using this branch with Grunt .4? |
| var stylus = require('stylus'); | ||
| var s = stylus(srcCode); | ||
|
|
||
| grunt.util._.each(options, function(value, key) { |
There was a problem hiding this comment.
Just use native method forEach
There was a problem hiding this comment.
That means like Object.keys(options).forEach(function(key) { var value = options[key]; .... ?
|
Yes, I'm using grunt 0.4.0a and it seems working correctly. |
|
Ack! This should have been merged ages ago Ayumu, I'm very sorry. This has been fixed in another PR, so I am closing it. Grunt 0.4 will be released in the next week or so and you'll be able to get these changes from npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specified
options.pathsthen @import nib failed.And
options.urlfuncis ignored.The version of there are fixed this problems. :)