Adds 'watch-start' and 'watch-end' events #440
Conversation
| @@ -1,4 +1,4 @@ | |||
| # grunt-contrib-watch v0.6.1 [](https://travis-ci.org/gruntjs/grunt-contrib-watch) | |||
| # grunt-contrib-watch v0.7.0 [](https://travis-ci.org/gruntjs/grunt-contrib-watch) | |||
There was a problem hiding this comment.
dont change this, it is autogenerated
There was a problem hiding this comment.
I think this was updated for the purpose of our fork. The first commit is probably the only one needed and versioning can be handled whenever you guys do the next release.
|
Addressed comments @eddiemonge. Let me know if you need anything else 👍 |
|
You should squash your commits down to one |
haroldtreen
force-pushed
the
master
branch
3 times, most recently
from
1743d0f
to
7bb488e
Compare
|
Squashing complete |
| @@ -203,7 +203,7 @@ Set `options: { cwd: { files: 'a/path', event: 'a/path' }}` to strip off `a/path | |||
|
|
|||
|
|
|||
| ## options.livereloadOnError | |||
| Type: `Boolean` | |||
| Default: `true` | |||
| Type: `Boolean` | |||
There was a problem hiding this comment.
These trailing spaces are needed.
There was a problem hiding this comment.
why? why doesnt 197 have them?
There was a problem hiding this comment.
2 trailing spaces = line break in markdown.
The fact that it's missing in line 197 doesn't mean it should be removed here.
There was a problem hiding this comment.
And in fact it's not missing in line 197; I fixed those the other day 2345454
haroldtreen
force-pushed
the
master
branch
2 times, most recently
from
ba35fe7
to
e1f1c27
Compare
|
Whitespace restored |
|
What is with this pull request? Did this 'fix' got implemented in some other commit? |
|
Unfortunately this needs to be rebased and I can't seem to be able to push on @haroldtreen's fork. |
|
I don't need this anymore, so I'll close. |
Built the functionality I was looking for in this issue: #437
Changes make grunt events to be emitted for:
watch-start: Fires right before watch tasks beginwatch-end: Fires right after all tasks have completed