Updates the grunt-contrib handlebars task to support partial compilation and injection. #106
Conversation
|
This looks great Dave. Apart from that notation I made, I'd be happy to merge this! I might make some small changes to the documentation text, but nothing major. Also, could you squash your commits? |
|
Sure, I'll modify and squash :) |
| @@ -1,5 +1,5 @@ | |||
| ## Compile handlebars templates to JST file | |||
| > Contributed By: [Tim Branyen](/tbranyen) (@tbranyen) | |||
| > Contributions: [Tim Branyen](/tbranyen) (@tbranyen), [Dave Mosher](/davemo) (@davemo) | |||
There was a problem hiding this comment.
im pretty sure we want to phase out the use of secondary contribs in docs. as when your pull gets merged in you would show up in the GH list of contributors.
There was a problem hiding this comment.
sure, should I delete the line or revert this portion of the commit?
…on into Handlebars.partials
|
Reverted contributor change. |
|
thanks. ill let @tkellen review the rest as he is more the handlebars guy :) |
|
Hey dave! I had to rebase your changes on to our master, there was a minor conflict with some stuff on the repo that happened after you submitted this. Unfortunately, github's interface isn't smart enough to deal with that sort of thing so I did it manually. I'm closing this pull request, but your code is in! Thanks a ton. |
|
Glad I could help out :) |
I've updated the test, docs and code. This seems to work pretty well, hopefully the code conforms to the style guides.