This repository has been archived by the owner on May 20, 2018. It is now read-only.
LESS improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both were only used once and could cause collisions. `log` was being set to global.
- Fix the style of a couple things. - Use grunt.fail.warn to prevent ambiguity. - Remove some stuff from the end of the task because they made no sense and were essentially useless.
IMPORTANT NOTE: Apparently, .parse() doesn't play nice when called more than once at a time. Therefore, async.forEachSeries() is REQUIRED instead of async.forEach(). This took far too long to realize :(
|
commit looks nice. ill have to try it out and update my recess implementation to a more async design and share it ;) |
|
Great commit Teddy--thanks very much for the submission! Some of the cruft you removed is left-over from rewrites that were required to support grunts rapidly changing API early on. It probably wouldn't hurt to do something similar on the rest of the tasks (remove the log/file vars, etc). If you feel like it, go for it! If not, I'll get to it eventually. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #21. Uses the included async library to make things play nicely with each other. Comes with tests.
Some notes:
.parse()doesn't play nicely when called in parallel. Switched it to useasync.forEachSeries()instead ofasync.forEach()and everything worked fine...Enjoy!
/bedtime