Skip to content
This repository has been archived by the owner on May 20, 2018. It is now read-only.

Option Test Patch #27

Merged
merged 1 commit into from
Jun 3, 2012
Merged

Option Test Patch #27

merged 1 commit into from
Jun 3, 2012

Conversation

ctalkington
Copy link
Member

This should fix the option test bug introduced by #25. It boils down to you have to completely reload the tasks within nodeunit tests. For some reason, npm test isn't effected but grunt test is, maybe due to scope?

@ctalkington
Copy link
Member Author

cc @tkellen

@ctalkington
Copy link
Member Author

once this is merged, i can patch #13 and #26.

tkellen pushed a commit that referenced this pull request Jun 3, 2012
@tkellen tkellen merged commit e9a3286 into gruntjs:master Jun 3, 2012
@ctalkington
Copy link
Member Author

@tkellen did this resolve the issues you were having with options?

@tkellen
Copy link
Member

tkellen commented Jun 3, 2012

yup. everything looks good now--thanks for all the great work! tomorrow, i'll get this test suite running on travis.ci

@ctalkington
Copy link
Member Author

@tkellen neat, haven't messed with Travis but its nice to have auto testing. Oh and I will do one more pass over zip after rebasing, hopefully it doesn't blow up on me again! should be def be good for tomorrow then maybe cut a release?

@tkellen
Copy link
Member

tkellen commented Jun 3, 2012

sounds like a plan!

@ctalkington
Copy link
Member Author

@tkellen have you considered using tags now that things are taking off? I think it would be a nice touch to compare between releases and such.

@tkellen
Copy link
Member

tkellen commented Jun 3, 2012

yup! i'll start using tags once we get to 0.1.0

@ctalkington
Copy link
Member Author

whats the goal between now and then? i know this is like an addon pack for grunt but maybe we should start wiki and get roadmap going, I am willing to dedicate some time each month towards it.

@tkellen
Copy link
Member

tkellen commented Jun 3, 2012

grunt 0.4.0 needs to drop, and I want completed docs for all the tasks (and a listing of tasks & links to said docs in the main README). I also want to talk with errcw about changing the jade task from src / dest keys to dest: ['src','src'...] for consistency with all the other tasks. If you have the time/inclinaton to tackle any of that, I'd greatly appreciate it.

@ctalkington
Copy link
Member Author

@tkellen I can prob help out with the jade task if errcw is busy or such. shouldn't be too bad as i've wrote three tasks in the "new" style. README would be good, what do you want to do for docs, like parameter listings or links to related library?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants