-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lodash is modified for all npm packages using the same lodash version #17
Comments
Wow nice find, thanks a bunch for digging into this!
In other words, if we remove |
Thanks @shama 👍 |
…tside instances. See: #17 If grunt-legacy-util has the same version of lodash as another library outside of Grunt, underscore.string overwrites the lodash same named lodash functions.
Fixes GH-17 The Object.create solution I implemented #18 wasn't a good one. As it breaks calling the lodash function directly: grunt.util._() Lodash has a function to create our own instance though: runInContext which is a better solution and still fixes the original issue so we dont pollute other lodash instances.
see gruntjs/grunt-legacy-log#26
grunt-legacy-util has the same problem and overrides the lodash functions for all npm packages using the same lodash version!
grunt-legacy-util/index.js
Lines 30 to 32 in 8034177
The text was updated successfully, but these errors were encountered: