Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coffeescript from dependencies. #1675

Merged
merged 1 commit into from Jun 29, 2020

Conversation

@STRML
Copy link
Contributor

@STRML STRML commented Apr 24, 2019

gruntjs/grunt-cli#117 removes the need for coffeescript in grunt by using Liftoff instead.

To ease transition, if coffeescript is still around, Grunt will attempt to load it. If it is not, and the user loads a CoffeeScript file, Grunt will print a useful error indicating that the coffeescript package should be installed as a dev dependency.

This is considerably more user-friendly than dropping the require entirely, but doing so is feasible with the latest grunt-cli as users may simply use grunt --require coffeescript/register.

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Apr 24, 2019

CLA assistant check
All committers have signed the CLA.

To ease transition, if the coffeescript package is still around, Grunt will
attempt to load it. If it is not, and the user loads a CoffeeScript file,
Grunt will print a useful error indicating that the coffeescript package
should be installed as a dev dependency.
@STRML STRML force-pushed the remove-coffeescript branch from a859006 to ba492b6 Apr 24, 2019
@vladikoff vladikoff merged commit 5f16b5a into gruntjs:master Jun 29, 2020
2 checks passed
@STRML STRML deleted the remove-coffeescript branch Jun 29, 2020
daniellockyer added a commit to TryGhost/Ghost that referenced this issue Jul 21, 2020
refs gruntjs/grunt#1675

- Grunt 1.2.0 removed coffeescript as a dependency, opting to leave it
  to the users to install
- we use `grunt-bg-shell`, which is built in coffeescript and therefore
  needs the dependency else `grunt dev` doesn't work
- I don't like needing to add coffeescript but it'll do until we give
  the dev experience a good cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants