Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and testing workflow #1750

Merged
merged 4 commits into from Jan 29, 2023
Merged

Update dependencies and testing workflow #1750

merged 4 commits into from Jan 29, 2023

Conversation

vladikoff
Copy link
Member

No description provided.

@vladikoff vladikoff merged commit 2805dc3 into main Jan 29, 2023
"findup-sync": "~0.3.0",
"glob": "~7.1.6",
"findup-sync": "~5.0.0",
"glob": "~8.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladikoff just FYI this bump could wreak havoc for Windows users since backslashes need to be escaped in v8.x.

@@ -7,7 +7,7 @@
"repository": "https://github.com/gruntjs/grunt.git",
"license": "MIT",
"engines": {
"node": ">=8"
"node": ">=16"
Copy link

@newhouse newhouse Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I think that if you're following Semver, this is a breaking change, requiring a major version bump. Yet this was published in a minor version bump (1.5.X => 1.6.0).

This means that packages (like spectaql) that had something like this in their dependencies will now break for installations on Node < 16:

{
  ...
  "dependencies": {
    ...
    "grunt": "^1.5.3",
    ...
  }
  ...
}

@vladikoff @XhmikosR

UPDATE: already noticed in #1751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants