Fix bug in file.expand/recurse when options.cwd is not set in Node 0.10.0 #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path.join arguments must be strings
|
+1 this error affects a good amount of the plugins on node v0.10.0 |
|
Actually it might be better to |
jrolfs
added a commit
to jrolfs/grunt
that referenced
this pull request
Mar 16, 2013
* master: quote version number for travis add node 0.10 to travis Bumping version to 0.4.1 and publishing to npm. Fix path.join thrown errors with expandMapping rename. Closes gruntjsgh-725. Update copyright date to 2013. Closes gruntjsgh-660. Remove some side effects from manually requiring Grunt. Closes gruntjsgh-605. grunt.log: add formatting support and implicitly cast msg to a string. Closes gruntjsgh-703. Update js-yaml to version 2. Closes gruntjsgh-683. The grunt.util.spawn method now falls back to stdout when the `grunt` option is set. Closes gruntjsgh-691. Making --verbose "Files:" warnings less scary. Closes gruntjsgh-657. Fixing typo: the grunt.fatal method now defaults to FATAL_ERROR. Closes gruntjsgh-656, gruntjsgh-707. Removed a duplicate line. Closes gruntjsgh-702. Gruntfile name should no longer be case sensitive. Closes gruntjsgh-685. The grunt.file.delete method warns and returns false if file doesn't exist. Closes gruntjsgh-635, gruntjsgh-714. The grunt.package property is now resolved via require(). Closes gruntjsgh-704. The grunt.util.spawn method no longer breaks on multibyte stdio. Closes gruntjsgh-710. Fix "path.join arguments must be strings" error in file.expand/recurse when options.cwd is not set. Closes gruntjsgh-722. Adding a fairly relevant keyword to package.json. Bumping version for development.
theasta
added a commit
to theasta/grunt
that referenced
this pull request
Apr 20, 2013
* upstream/master: (21 commits) Add grunt logo to readme npmignore unneeded files quote version number for travis add node 0.10 to travis Bumping version to 0.4.1 and publishing to npm. Fix path.join thrown errors with expandMapping rename. Closes gruntjsgh-725. Update copyright date to 2013. Closes gruntjsgh-660. Remove some side effects from manually requiring Grunt. Closes gruntjsgh-605. grunt.log: add formatting support and implicitly cast msg to a string. Closes gruntjsgh-703. Update js-yaml to version 2. Closes gruntjsgh-683. The grunt.util.spawn method now falls back to stdout when the `grunt` option is set. Closes gruntjsgh-691. Making --verbose "Files:" warnings less scary. Closes gruntjsgh-657. Fixing typo: the grunt.fatal method now defaults to FATAL_ERROR. Closes gruntjsgh-656, gruntjsgh-707. Removed a duplicate line. Closes gruntjsgh-702. Gruntfile name should no longer be case sensitive. Closes gruntjsgh-685. The grunt.file.delete method warns and returns false if file doesn't exist. Closes gruntjsgh-635, gruntjsgh-714. The grunt.package property is now resolved via require(). Closes gruntjsgh-704. The grunt.util.spawn method no longer breaks on multibyte stdio. Closes gruntjsgh-710. Fix "path.join arguments must be strings" error in file.expand/recurse when options.cwd is not set. Closes gruntjsgh-722. Adding a fairly relevant keyword to package.json. ...
tschaub
added a commit
to tschaub/grunt-gh-pages
that referenced
this pull request
May 13, 2013
The grunt used by Travis doesn't have this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.join arguments must be strings