Add helper to read environment variables #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
commented
Mar 9, 2017
| @@ -202,10 +202,14 @@ hooks: | |||
| - command: <CMD> | |||
| args: | |||
| - <ARG> | |||
| env: | |||
| <KEY>: <VALUE> | |||
There was a problem hiding this comment.
Note: in the previous PR, I made my docs changes to the root README file. I forgot that in this repo, the README in the root folder is actually generated from the _docs folder, so I've had to redo those doc changes in the proper place in this PR :)
brikis98
commented
Mar 9, 2017
| * `templateFolder`: Return the value of the `--template-folder` command-line option. Useful for building relative paths. | ||
| * `outputFolder`: Return the value of the `--output-folder` command-line option. Useful for building relative paths. | ||
|
|
||
| * `env NAME DEFAULT`: Render the value of environment variable `NAME`. If that environment variable is empty or not | ||
| defined, render `DEFAULT` instead. |
There was a problem hiding this comment.
This is the only change to the docs that's relevant for this PR
There was a problem hiding this comment.
+1 on implementing a getOrElse() here.
|
Merging this now. |
josh-padnick
reviewed
Mar 9, 2017
| * `templateFolder`: Return the value of the `--template-folder` command-line option. Useful for building relative paths. | ||
| * `outputFolder`: Return the value of the `--output-folder` command-line option. Useful for building relative paths. | ||
|
|
||
| * `env NAME DEFAULT`: Render the value of environment variable `NAME`. If that environment variable is empty or not | ||
| defined, render `DEFAULT` instead. |
There was a problem hiding this comment.
+1 on implementing a getOrElse() here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, I added a helper to set environment variables when using the
shellhelper orhooks. This PR adds a helper to read environment variables. The nice thing is that these helpers are composable: that is, you can use the helper to read env vars both with theshellhelper and withhooks.