Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sprig #49

Merged
merged 7 commits into from May 15, 2019
Merged

Introduce sprig #49

merged 7 commits into from May 15, 2019

Conversation

yorinasub17
Copy link
Contributor

@yorinasub17 yorinasub17 commented May 14, 2019

This integrates sprig into boilerplate so that the sprig functions are available in the templates rendered by `boilerplate.

Note that this isn't a straightforward integration. There are many functions that boilerplate provides that overlap with sprig that have conflicting behavior. To address these, I created an alias for the boilerplate and sprig versions so that both are available, with notes on which ones are supported and which ones are deprecated. See the README update for more details.

This PR also has a few miscellaneous improvements:

  • Switch from glide to dep for golang dependency management.
  • Update circleci config to use later versions for many things.
  • Use gruntwork-cli help text formatters to make it more consistent with our other CLI tools.
  • Run gofmt on the files I touched (automatically done by editor).

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great improvements, thanks Yori! 👍

@yorinasub17
Copy link
Contributor Author

Going to merge and release this!

@yorinasub17 yorinasub17 merged commit 985b793 into master May 15, 2019
@yorinasub17 yorinasub17 deleted the yori-sprig branch May 15, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants