Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency var_files #73

Merged
merged 4 commits into from Dec 4, 2020
Merged

Dependency var_files #73

merged 4 commits into from Dec 4, 2020

Conversation

yorinasub17
Copy link
Contributor

This implements support for specifying var_files on a dependency so that you can import all the vars written out to a var file when invoking the dependency. The use case for this is that this can make it possible for customers to write a top level boilerplate.yml configuration that encodes both:

  • the template to invoke
  • the variable values to invoke with

This is most useful in the Reference Architecture deployment, where we can provide customers with a repeatable configuration artifact that lets them recreate the whole ref arch code. Not to mention the nice side effect of providing them with the version that was used to render everything.

@yorinasub17
Copy link
Contributor Author

NOTE: The dependencies-remote test is expected to fail, because it points to master and the updated text files are only in this branch.

Copy link
Contributor

@bwhaley bwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will make for such a smooth hand off with the customer.

@yorinasub17
Copy link
Contributor Author

Thanks for review! Going to merge this in now. Won't cut a release until I confirm the tests are passing.

@yorinasub17 yorinasub17 merged commit 636d119 into master Dec 4, 2020
@yorinasub17 yorinasub17 deleted the yori-dependency-varfiles branch December 4, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants