Add support for nuking secrets manager secrets #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for review! I looked into the test failures, and they are unrelated to this change: One is about Transit gateway and us hitting limits in our account. I'll open a new PR to stabilize the build. |
|
Thanks for review! Going to merge this in as the build is passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes support for nuking Secrets Manager secrets, including usage of the config file to restrict what secrets should be nuked, and an update to our config file to ensure that only test secrets manager secrets are deleted in our environment.
NOTE: This was prompted from our internal investigation in to the AWS bill (notes available in notion).