Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Config to Capture all FilterRules and Apply to ApiGateway as prototype #499

Merged
merged 2 commits into from Jul 14, 2023

Conversation

hongil0316
Copy link
Contributor

@hongil0316 hongil0316 commented Jul 14, 2023

… prototype

Description

Config improvement mentioned here: https://www.notion.so/gruntwork/Cloud-Nuke-Restructure-Proposal-845f291e952844ae8b0054ad0e466cfc.

Tested running unit tests + locally running the cloud-nuke command

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Refactor Config to Capture all FilterRules and Apply to ApiGateway as prototype]

Migration Guide

@hongil0316 hongil0316 merged commit 147b088 into master Jul 14, 2023
2 of 3 checks passed
@hongil0316 hongil0316 deleted the config_improvement branch July 14, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants