Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RDS Cluster ResourceType #502

Merged
merged 2 commits into from Jul 19, 2023
Merged

Refactor RDS Cluster ResourceType #502

merged 2 commits into from Jul 19, 2023

Conversation

hongil0316
Copy link
Contributor

Description

Tackling issue: #494

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Refactor RDS Cluster ResourceType]

Migration Guide

aws/rds_cluster.go Outdated Show resolved Hide resolved
aws/rds_cluster.go Outdated Show resolved Hide resolved
aws/rds_cluster.go Outdated Show resolved Hide resolved
aws/rds_cluster.go Outdated Show resolved Hide resolved
aws/rds_cluster.go Outdated Show resolved Hide resolved
MoonMoon1919
MoonMoon1919 previously approved these changes Jul 17, 2023
MoonMoon1919
MoonMoon1919 previously approved these changes Jul 18, 2023
@hongil0316 hongil0316 merged commit ec245e5 into master Jul 19, 2023
2 of 3 checks passed
@hongil0316 hongil0316 deleted the TestNukeRDSCluster branch July 19, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants