Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wait logic in transite gateway attachment #633

Merged
merged 1 commit into from Jan 26, 2024

Conversation

hongil0316
Copy link
Contributor

Description

Fixes #624.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@yhakbar
Copy link

yhakbar commented Jan 22, 2024

Why not use a waiter, @hongil0316 ?

@hongil0316
Copy link
Contributor Author

Why not use a waiter, @hongil0316 ?

I wasn't actually aware of this approach. However, currently most of the resources are using SDK v1 and the wait logic is implemented similar to the change being implemented here. If we want to introduce this, I think we should do it in a separate PR with bigger plan for consistency across the code base.

@hongil0316 hongil0316 merged commit c0fce6e into master Jan 26, 2024
3 checks passed
@hongil0316 hongil0316 deleted the transite_gateway branch January 26, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Not waiting long enough for Transit Gateway resources to nuke
2 participants