Make printed table markdown-friendly #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoboat
commented
Jun 24, 2022
| printer.BorderTop, printer.BorderBottom, printer.BorderLeft, printer.BorderRight = false, false, true, true | ||
| printer.CenterSeparator = "|" | ||
| printer.ColumnSeparator = "|" | ||
| printer.RowSeparator = "-" |
There was a problem hiding this comment.
Not sure if we just use different characters because of our different operating systems, but I always have to sed these manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change uses different characters for the pipe and hyphen when printing tables and removes the top and bottom borders.
Not sure if this makes sense to all users. The table may not look as nice in the CLI, but it can be more easily copy-pasted into GitHub issues/PRs and other markdown needs. It doesn't seem worth having a separate
--render-markdownflag.TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Updated the table outputs to be markdown friendly.
Migration Guide
(I don't think this warrants a migration guide even though changes are made to outputs.)