Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patcher home page is wider than it should. #628

Closed
ina-stoyanova opened this issue Aug 25, 2021 · 3 comments · Fixed by #630
Closed

Patcher home page is wider than it should. #628

ina-stoyanova opened this issue Aug 25, 2021 · 3 comments · Fixed by #630
Assignees
Milestone

Comments

@ina-stoyanova
Copy link
Contributor

CPT2108251307-1202x761

@ina-stoyanova
Copy link
Contributor Author

This is happening on gruntwork.io & locally on master too, so I believe it hasn't been fixed in any of the more recent PR's

@ina-stoyanova ina-stoyanova self-assigned this Aug 25, 2021
@ina-stoyanova
Copy link
Contributor Author

ina-stoyanova commented Aug 25, 2021

Tagging @zackproser @brikis98 to get your thoughts on this!

So after digging into this, me & @marinalimeira found out it's because of the "how it works" section. After pairing with @brikis98 we also realised it's because we were rendering an empty image tag with a set width. See fix PR here: https://github.com/gruntwork-io/gruntwork-io.github.io/compare/landing/patcher-fix-wider-page?expand=1.

Another last thing we noticed was that the gif expanding (the first one) has a reference to the renovate Github app. That's not easy to see, but once you know it, you know it :D

@ina-stoyanova ina-stoyanova linked a pull request Aug 25, 2021 that will close this issue
@zackproser
Copy link
Contributor

Tagging @zackproser @brikis98 to get your thoughts on this!

So after digging into this, me & @marinalimeira found out it's because of the "how it works" section. After pairing with @brikis98 we also realised it's because we were rendering an empty image tag with a set width. See fix PR here: https://github.com/gruntwork-io/gruntwork-io.github.io/compare/landing/patcher-fix-wider-page?expand=1.

Another last thing we noticed was that the gif expanding (the first one) has a reference to the renovate Github app. That's not easy to see, but once you know it, you know it :D

Thanks for spotting and fixing this @ina-stoyanova and @marinalimeira! I will re-create the gif now to remove the reference to renovate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants