Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksums to release files #14

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add checksums to release files #14

merged 1 commit into from
Mar 4, 2019

Conversation

conn
Copy link
Contributor

@conn conn commented Mar 2, 2019

This is to address an unopened issue similar to:
gruntwork-io/terragrunt#610

The checksums of all binaries within bin/ will be saved within
SHA256SUMS. The integrity of binaries can now be verified with this
command: sha256sum --check --ignore-missing SHA256SUMS.

In the future, Gruntwork should consider using a PGP key to
cryptographically sign this checksums file and to distribute the
signature along with the rest of the release files. Doing so will likely
require using private CI/CD infrastructure instead of CircleCI so that
Gruntwork may have full control over their private signing key.

This is to address an unopened issue similar to:
gruntwork-io/terragrunt#610

The checksums of all binaries within `bin/` will be saved within
`SHA256SUMS`. The integrity of binaries can now be verified with this
command: `sha256sum --check --ignore-missing SHA256SUMS`.

In the future, Gruntwork should consider using a PGP key to
cryptographically sign this checksums file and to distribute the
signature along with the rest of the release files. Doing so will likely
require using private CI/CD infrastructure instead of CircleCI so that
Gruntwork may have full control over their private signing key.
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the PRs! 👍

Let me merge this in, do a release, and see if it works. If it does, we'll merge in the other similar PRs you submitted.

@brikis98 brikis98 merged commit 7724958 into gruntwork-io:master Mar 4, 2019
@brikis98
Copy link
Member

brikis98 commented Mar 4, 2019

Looks like that worked perfectly, thank you!

https://github.com/gruntwork-io/health-checker/releases/tag/v0.0.4

@conn
Copy link
Contributor Author

conn commented Mar 4, 2019

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants