Surfacing Additional Pod Labels for user #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
reviewed
Sep 8, 2020
yorinasub17
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #74
Added two arguments to the values template and in the deployment to allow a user to add additional labels to their pod and deployment. These are provided by additionalDeploymentLabels:{} and additionalPodLabels:{} that the user can provide a map to the same as the annotations arguments.
I was contemplating adding something to the matchLabels as well but I felt that might open up a can of worms with the core functionality of the template providing a single deployment so I left that in the end.
The main aim is to allow users to integrate gruntwork templates with other labelling schemes they would be running in their k8s workload as well as the mentioned use case in the issue where labels are required for certain tagging and operational uses by other systems.
I don't think there should be any reason for compatibility issues for existing users.