Tf12 Upgrade #17
Merged
Tf12 Upgrade #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Jun 5, 2019
|
|
||
| * [intermediate-variable](/modules/intermediate-variable): This module has been superseded by [terraform local | ||
| values](https://www.terraform.io/docs/configuration/locals.html). To upgrade, switch usage of `intermediate-variable` | ||
| with `locals`. |
Updated all the input vars to have concrete types. However, I couldn't use |
|
Ok addressed the comment, so going to merge and release this. Our first tf12 module! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all the modules to be tf12 compatible. Additionally, implements the following enhancements:
intermediate-variable, as it is superseded bylocalsand customers should upgrade to using that as part of upgrading to tf12.