This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
GKE resource labels #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
add optional GCP resource labels to GKE cluster
robmorgan
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Hi @jsirianni,
Thanks for the PR! It looks good so far, I've added one minor suggestion. Also, would you mind rolling this out to all of the examples for consistency?
Cheers,
Rob
|
Thanks for the quick turnaround @robmorgan. Please let me know if you need anything else. |
|
@jsirianni LGTM! |
robmorgan
approved these changes
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use-case that requires resource labels on GKE for costing / billing filtering. This PR adds optional resource labels for GKE clusters.
Default behavior is not modified.
My tests passed when I ran
go test -v -timeout 60m -run ./gke_cluster_test.go.