This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileykarson
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Net ~150 line removal. Nice!
changes LGTM if you're looking for an approval
@@ -16,6 +16,12 @@ variable "namespace" { | |||
# These variables have defaults, but may be overridden by the operator. | |||
# --------------------------------------------------------------------------------------------------------------------- | |||
|
|||
# Workaround terraform limitation where resource count can not include interpolated lists. | |||
variable "num_rbac_roles" { | |||
description = "Number of RBAC roles to bind. This should match the number of items in the list passed to rbac_roles." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that's so sad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea... I added a link to the github issue that talks about this limitation for more reference.
yorinasub17
commented
Jan 18, 2019
Thanks @rileykarson ! Will merge and release when the build passes. |
Build passed, so merging and releasing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
k8s-namespace
andk8s-service-account
modules to use the new resources that were just released around RBAC role management.