Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Use kubernetes provider #7

Merged
merged 5 commits into from Jan 18, 2019
Merged

Use kubernetes provider #7

merged 5 commits into from Jan 18, 2019

Conversation

yorinasub17
Copy link
Contributor

This updates the k8s-namespace and k8s-service-account modules to use the new resources that were just released around RBAC role management.

Copy link
Contributor

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Net ~150 line removal. Nice!

changes LGTM if you're looking for an approval

@@ -16,6 +16,12 @@ variable "namespace" {
# These variables have defaults, but may be overridden by the operator.
# ---------------------------------------------------------------------------------------------------------------------

# Workaround terraform limitation where resource count can not include interpolated lists.
variable "num_rbac_roles" {
description = "Number of RBAC roles to bind. This should match the number of items in the list passed to rbac_roles."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's so sad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... I added a link to the github issue that talks about this limitation for more reference.

@yorinasub17
Copy link
Contributor Author

Thanks @rileykarson ! Will merge and release when the build passes.

@yorinasub17
Copy link
Contributor Author

Build passed, so merging and releasing

@yorinasub17 yorinasub17 merged commit 87ac1cf into master Jan 18, 2019
@yorinasub17 yorinasub17 deleted the yori-use-kube-provider branch January 18, 2019 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants