adding env var for --terragrunt-include-external-dependencies #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
reviewed
Mar 22, 2021
cli/args.go
Outdated
| @@ -103,7 +103,7 @@ func parseTerragruntOptionsFromArgs(terragruntVersion string, args []string, wri | |||
|
|
|||
| ignoreExternalDependencies := parseBooleanArg(args, OPT_TERRAGRUNT_IGNORE_EXTERNAL_DEPENDENCIES, false) | |||
|
|
|||
| includeExternalDependencies := parseBooleanArg(args, OPT_TERRAGRUNT_INCLUDE_EXTERNAL_DEPENDENCIES, false) | |||
| includeExternalDependencies := parseBooleanArg(args, OPT_TERRAGRUNT_INCLUDE_EXTERNAL_DEPENDENCIES, func() bool { _, b := os.LookupEnv("TERRAGRUNT_INCLUDE_EXTERNAL_DEPENDENCIES"); return b }()) | |||
There was a problem hiding this comment.
Why use a self-calling function here?
configstack/stack.go
Outdated
| @@ -81,12 +81,6 @@ func (stack *Stack) Run(terragruntOptions *options.TerragruntOptions) error { | |||
| func (stack *Stack) summarizePlanAllErrors(terragruntOptions *options.TerragruntOptions, errorStreams []bytes.Buffer) { | |||
| for i, errorStream := range errorStreams { | |||
| output := errorStream.String() | |||
|
|
|||
There was a problem hiding this comment.
This shouldn't be part of this PR?
| - [terragrunt-check](#terragrunt-check) | ||
| - [terragrunt-hclfmt-file](#terragrunt-hclfmt-file) | ||
| - [terragrunt-override-attr](#terragrunt-override-attr) | ||
| - [CLI commands](#cli-commands) |
There was a problem hiding this comment.
This shouldn't be part of this PR?
| @@ -512,7 +526,8 @@ directories. | |||
|
|
|||
| **CLI Arg**: `--terragrunt-ignore-dependency-order` | |||
|
|
|||
| When passed in, ignore the depedencies between modules when running `*-all` commands. | |||
| **CLI Arg**: `--terragrunt-include-external-dependencies`</br> | |||
| **Environment Variable**: `TERRAGRUNT_INCLUDE_EXTERNAL_DEPENDENCIES` (set to `false`)</br> | |||
|
@brikis98 hey, thank you for the review! I'm going to catch my fork up to current HEAD and address your issues. |
added 5 commits
June 4, 2021 13:38
Revert "Revert "Fix empty outputs (gruntwork-io#1568)"" This reverts commit f286021.
|
@brikis98 sorry about the hassle on the strange commit for I think all your comments are addressed now. |
brikis98
approved these changes
Jun 7, 2021
|
Tests passed! Merging now. |
1 task
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
We've been running into the same issue as #1418 and gruntwork-io/terratest/issues/699. This small patch provides the ability to use an environment var with the expected behavior.
I looked through the tests around this code and didn't see where the env var bits for cli flags were tested. I'm happy to add coverage for this or discuss any required changes.
Let me know what thoughts are around the change.
Edit: forgot to include test run output, gist link here - not sure if the full integration tests need to pass as well, in which case I'll need to read through what is required in AWS and plan accordingly.