Correctly Mirror Terraform GCP Auth #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmorgan
requested review from
autero1,
brikis98 and
eak12913
as code owners
yorinasub17
reviewed
Oct 12, 2019
| defaultCreds := os.Getenv("GCLOUD_SERVICE_KEY") | ||
| defer os.Setenv("GCLOUD_SERVICE_KEY", defaultCreds) | ||
| os.Unsetenv("GCLOUD_SERVICE_KEY") | ||
| os.Setenv("GOOGLE_CREDENTIALS", defaultCreds) |
There was a problem hiding this comment.
You might want to disable t.Parallel for this test to avoid colliding with other tests that might expect these env vars.
|
@yorinasub17 looks like the build passes now, should I merge? https://circleci.com/gh/gruntwork-io/terragrunt/3237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for correctly mirroring the Terraform GCP authentication behavior by supporting the
GOOGLE_CREDENTIALSenvironment variable. Users can either pass in the contents or path to a credentials file.