Fix bug where fallback to aws node fails #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Jun 25, 2020
| @@ -25,6 +25,7 @@ require ( | |||
| github.com/gruntwork-io/gruntwork-cli v0.5.1 | |||
| github.com/imdario/mergo v0.3.7 // indirect | |||
| github.com/jstemmer/go-junit-report v0.9.1 | |||
| github.com/magiconair/properties v1.8.0 | |||
There was a problem hiding this comment.
Yea. I ran go mod tidy and it showed up, indicating that we forgot to add this in in some other PR.
|
Thanks for review! Going to merge and release this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559
The fallback was failing because the public IP map did contain an entry for the instance, but it was the blank string. This fixes the bug by explicitly checking for empty string.