Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Virtual Machine module #641

Merged
merged 64 commits into from Oct 22, 2020

Conversation

davesee
Copy link
Contributor

@davesee davesee commented Sep 16, 2020

Adding more comprehensive VM and dependency resource tests.

Fixes #635

@davesee
Copy link
Contributor Author

davesee commented Sep 28, 2020

@davesee
Copy link
Contributor Author

davesee commented Oct 3, 2020

@davesee
Copy link
Contributor Author

davesee commented Oct 4, 2020

Copy link
Contributor

@rguthriemsft rguthriemsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

rguthriemsft
rguthriemsft previously approved these changes Oct 6, 2020
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close. I left a bunch of comments, but they are almost almost all NITs or questions about nil. We really have to be careful to avoid a nil pointer dereference or anything else that causes a panic in Terratest, as a panic will kill the test suite part way through, preventing any cleanup code from running.

examples/azure/terraform-azure-vm-example/main.tf Outdated Show resolved Hide resolved
modules/azure/compute.go Show resolved Hide resolved
modules/azure/compute.go Show resolved Hide resolved
modules/azure/compute.go Outdated Show resolved Hide resolved
modules/azure/compute_test.go Show resolved Hide resolved
modules/azure/disk.go Show resolved Hide resolved
test/azure/terraform_azure_example_test.go Show resolved Hide resolved
test/azure/terraform_azure_vm_example_test.go Outdated Show resolved Hide resolved
@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/305145049

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/305145049

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/305145049

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; success 👍

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/305145049

Copy link
Contributor

@rguthriemsft rguthriemsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorinasub17 @brikis98 Look good to me

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor

Pardon the delay in reviewing this, but this is good to go now! Thanks for the contribution! Will merge and release.

@yorinasub17 yorinasub17 merged commit 5fa1994 into gruntwork-io:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Azure Virtual Machine module
5 participants