Use terraform-json to have better terraform plan testing #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to hold off merging this until we resolve the build issues with #756 |
yorinasub17
force-pushed
the
yori-better-plan-testing
branch
from
57eb06d
to
c0c1857
Compare
|
Thanks for review. I ran the build a few times, and different tests fail each time, and they are all unrelated to this PR, so going to go ahead and merge this in. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our opensource policy allows MPL, here is a PR that updates our examples to use
terraform-json. Note that this also implements a struct that wraps terraform-json to provide a more ergonomic interface to navigate the plan struct by providing a map that maps the resource addresses to the corresponding struct values.