Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terraform] Add Terraform Validate function #866

Merged
merged 1 commit into from
Apr 16, 2021
Merged

[Terraform] Add Terraform Validate function #866

merged 1 commit into from
Apr 16, 2021

Conversation

axilleastr
Copy link

@axilleastr axilleastr commented Apr 12, 2021 •
edited

This PR addresses #855

Description:

What has been added:

  • terraform validate functions, that were missing from the terraform module

brikis98
brikis98 reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

modules/terraform/init.go Outdated Show resolved Hide resolved
modules/terraform/validate.go Outdated Show resolved Hide resolved
modules/terraform/validate.go Outdated Show resolved Hide resolved
@axilleastr axilleastr force-pushed the master branch 2 times, most recently from de07ff6 to 8803640 Compare April 13, 2021 16:49
brikis98
brikis98 reviewed Apr 15, 2021
View reviewed changes
modules/terraform/validate_test.go Outdated Show resolved Hide resolved
modules/terraform/validate_test.go Outdated Show resolved Hide resolved
brikis98
brikis98 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! I'll kick off tests now.

@brikis98
Copy link
Member

Tests passed! Merging now.

@brikis98 brikis98 merged commit a3dee0b into gruntwork-io:master Apr 16, 2021
@brikis98
Copy link
Member

https://github.com/gruntwork-io/terratest/releases/tag/v0.32.23

@brikis98 brikis98 mentioned this pull request Apr 16, 2021
Closed
This was referenced May 21, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@axilleastr @brikis98