Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AZURE] Expand KV authorizer options #945

Merged
merged 1 commit into from Jul 9, 2021
Merged

[AZURE] Expand KV authorizer options #945

merged 1 commit into from Jul 9, 2021

Conversation

HadwaAbdelhalem
Copy link
Contributor

This PR Expands the Azure Key Vault module Authorizer to offer Auth from Files, and Auth from Env variables

Fixes #903
Closes #903

@HadwaAbdelhalem
Copy link
Contributor Author

Link to passed CI . @yorinasub17 ready for your review

@HadwaAbdelhalem HadwaAbdelhalem changed the title Expand KV authorizer options [AZURE] Expand KV authorizer options Jul 9, 2021
yorinasub17
yorinasub17 approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll kick off a sanity check build to make sure our precommit hooks pass, and if it does, will merge this in.

@yorinasub17
Copy link
Contributor

And the precommit check passed, so will go forward with the merge!

@yorinasub17 yorinasub17 merged commit 0f0af4a into gruntwork-io:master Jul 9, 2021
This was referenced Jul 9, 2021
Merged
Merged
Merged
Merged
@paddymorgan84 paddymorgan84 mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorinasub17 yorinasub17 yorinasub17 approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure] Unable to check if key vault secret exists using environment variables
2 participants
@HadwaAbdelhalem @yorinasub17