Downstream sync #22
Merged
Downstream sync #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…already merged his branch to dev add NodeJS 16.x support. drop NodeJS 12.x support.It reached End-of-Life status on 30 April 2022 allow NodeJS 18.x support to run for CI upgrade webpack and webpack-cli update browserlist and browser documentation, config is now at .browserslistrc update README.md for browsers and Node versions fix typos in comments in lib/client/hashauth.js and webpack/webpack.config from #7440
…k.json with node v10.24.1
…verage pacakge (see issue #7515 ).
…odules, so the content is retained across cached builds in various PAAS environments
* Change | to && in package.json
… into PieterGit-dev20220815
The '^' prefix makes this meaingless, there's no reason to refuse to run less than 16.16.0 if it's still some 16.x.
…0815 Wip/bewest/pieter git dev20220815
New build artefact cache location
Avoid HTML injection called out by CODEQL.
See if this makes codeql happy.
Wip/bewest/code ql analysis
codeql text/html injection in food.js
Use npm install under node 14 generates different lock file.
This patch adjusts the user feedback while the server is initializing to communicate that Nightscout startup sequence should take closer to 15 second than 5 seconds.
Record output of npm instlal using oldest supported version.
Record changes from upgrading nightscout-connect to at least the latest release, 0.0.12.
Mongo driver update & less frequent database polls
New Crowdin updates
dev - candidate for release 15.0.0
Revert "Merge pull request #8026 from nightscout/less_frequent_db_upd…
Releasing 15.0.1, hotfix to revert series of changes affecting mongodb that were not quite ready.
The allowEIO3, when set to true allows v2 clients to connect while the default is false. This patch should allow versions of AndroidAPS older than 3.2 to connect to NS15 and above. Thanks to Dave Carlson for researching and experimenting with this option! https://socket.io/docs/v4/migrating-from-2-x-to-3-0/#how-to-upgrade-an-existing-production-deployment https://socket.io/docs/v4/server-options/#alloweio3
socket.io: enable legacy v2 connections
This patch is intended to allow customizing the behavior for whether or not to prompt for authorization before subscribing or acknolweding alarms. There was a bug in previous attempts where the profileeditor would be double initialized, causing the profileeditor to remove some buttons from the GUI. This patch adds checking for a permission specifically related to acknolwedging alarms, as well as avoids double-initializing the editor, which causes the issue with the GUI.
This patch eliminates debugging logging in favor of commentary to capture how, where, and why alarmSocket feature is causing different pages to demand the authentication prompt in a variety of circumstances.
Create an opportunity to respond with something other than a global ack when someone that is not authorized sends an acknolwedgement to an alarm. Eliminate double-initializing when subscribing to alarms. The `callback` variable is not local to the function, anyway.
When someone is looking at Nightscout and needs the alarm silenced, it is very desirable to always silence the local UI. This patch documents some of the working code around handling the alarm notification process, as well as provides commentary on handling unauthorized scenarios. There are some open questions such as how to update the permission set after authorization.
alarmSocket: customizing authorization requirements
Dev branch for next release, 15.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.