Refactor code handler #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lamenezes
commented
Oct 23, 2016
•
lamenezes
commented
- Remove test result handling from CodeHandler, since it should only watch the folder and run tests properly.
- Decouple notifier from most classes, it is now provided as an instance.
- Properly use python-2 style classes for better support
lamenezes
force-pushed
the
refactor-code-handler
branch
3 times, most recently
from
99f1cc0
to
5ec92d6
Compare
lamenezes
force-pushed
the
refactor-code-handler
branch
from
5ec92d6
to
c332085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.