report error when Gcd() is called with floating point argument

Task #107 - GCD: wrong answer with float
grzegorzmazur · Aug 21, 2015 · 0a1938c · 0a1938c
1 parent 90f613b
commit 0a1938c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/scripts/multivar.rep/code.ys b/scripts/multivar.rep/code.ys
@@ -76,7 +76,7 @@ MultiContentTerm(multi_IsMulti)
 MultiContentScan(_coefs,_fact) <--
 [
   Set(least,Min({least,coefs}));
-  Set(gcd,Gcd(gcd,fact));
+  Set(gcd,If(IsRational(gcd) And IsRational(fact), Gcd(gcd,fact), 1));
 ];
 UnFence("MultiContentScan",2);
 

diff --git a/scripts/stubs.rep/code.ys b/scripts/stubs.rep/code.ys
@@ -250,6 +250,9 @@ Sqrt(xlist_IsList) <-- MapSingle("Sqrt",xlist);
   NormalForm(Gcd(MakeUni(n,vars),MakeUni(m,vars)));
 ];
 
+90 # Gcd(x_IsNumber, _y) <-- Check(False, "Gcd: argument is not an exact number");
+90 # Gcd(_x, y_IsNumber) <-- Check(False, "Gcd: argument is not an exact number");
+
 100 # Gcd(n_IsConstant,m_IsConstant) <-- 1;
 
 30 # PolynomialGcd(n_CanBeUni, m_CanBeUni)_(Length(VarList(n*m))=1) <--

diff --git a/tests/regress.yts b/tests/regress.yts
@@ -391,9 +391,6 @@ Verify((Limit(x,0) (x+1)^(Ln(a)/x)), a);
    otherwise it's parsed as Limit (... = ...) */
 
 /* Bug #3 */
-KnownFailure(Gcd(10,3.3) != 3.3 And Gcd(10,3.3) != 1);
-/* I don't know what the answer should be, but buth 1 and 3.3 seem */
-/* certainly wrong. */
 Verify(Gcd(-10, 0), 10);
 Verify(Gcd(0, -10), 10);