Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation convenience constructors #154

Closed
grzi opened this issue Aug 2, 2021 · 4 comments · Fixed by #169
Closed

Animation convenience constructors #154

grzi opened this issue Aug 2, 2021 · 4 comments · Fixed by #169
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.5.0-jezzball

Comments

@grzi
Copy link
Owner

grzi commented Aug 2, 2021 •
edited

I would like to add :

Animation::running(...) -> Create an animation with 'RUNNING' status
Animation::looping(...) -> Create an animation with 'LOOPING' status

And delete the 'loop at start' boolean in the new fn
@grzi grzi added this to the 0.5.0-world-cup milestone Aug 2, 2021
@grzi grzi added enhancement New feature or request good first issue Good for newcomers labels Aug 2, 2021
@kaimuell
Copy link
Contributor

kaimuell commented Aug 4, 2021

Hey grzi. I could add those.

@grzi
Copy link
Owner Author

grzi commented Aug 11, 2021

@TheArtistGuy sûre ! Sorry didn't had ping of your message. Do you still want to try ?

@kaimuell
Copy link
Contributor

Yes. Solved the Issue.
Unfortunately Git says i don't have permission to push the feature branch. Do you have an Idea why?

Sorry, this is the first time i contribute to someone elses Projects.

@grzi
Copy link
Owner Author

grzi commented Aug 12, 2021

@TheArtistGuy No problem These issues are here to learn.

The 'right' approach when you want to contribute to someone's project on Github is :

  1. On the project page, click on 'fork' : This will create a copy of the project on your personal github
  2. Clone the project from your own github, make your devs and push your branch
  3. Create a MR from your repository to the original repository. (Github will normally highlight a button to create the MR)

kaimuell added a commit to kaimuell/scion that referenced this issue Aug 16, 2021
@kaimuell
grzi#154 animation convenience constructors
0dafc08
kaimuell added a commit to kaimuell/scion that referenced this issue Aug 16, 2021
@kaimuell
grzi#154 Animation convenience constructors
bd0e202
@kaimuell kaimuell mentioned this issue Aug 16, 2021
Merged
kaimuell added a commit to kaimuell/scion that referenced this issue Aug 17, 2021
@kaimuell
grzi#154 updated usages of animation
98a574b
kaimuell added a commit to kaimuell/scion that referenced this issue Aug 18, 2021
@kaimuell
grzi#154 fixed constructor in test
dc27853
@grzi grzi linked a pull request Aug 18, 2021 that will close this issue
Feature animation constructors #169
Merged
@grzi grzi closed this as completed in #169 Aug 18, 2021
grzi pushed a commit that referenced this issue Aug 18, 2021
@kaimuell
Feature animation constructors (#169)
0a0c081 
* #154 animation convenience constructors

* #154 Animation convenience constructors

* #154 updated usages of animation

* #154 fixed constructor in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.5.0-jezzball
Development

Successfully merging a pull request may close this issue.

Feature animation constructors kaimuell/scion
2 participants
@grzi @kaimuell