Fix - Disabled autoplay still fires events beforeChange
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChobotX
approved these changes
Feb 7, 2022
|
@kyuwoo-choi Sorry to bother, but can we merge this? Or at least get a review? 🙏 It's been 8 months and I'm using my fork in production lol |
|
Hi @kyuwoo-choi this bug is also breaking the could we please get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out my carousel was sending a lot of
beforeChangeevents even though nothing seemingly changed.I found out the condition to trigger the autoplay was wrong and so it always triggers the autoplay timer whatever the props are.
To avoid any more confusion, I renamed the
autoPlaymethod torunAutoPlay, so we're sure the names are more distincts than just a capital letter!