Rules updates #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the [camelcase](https://eslint.org/docs/rules/camelcase) rule to be more lenient. Removes the [sort-keys](https://eslint.org/docs/rules/sort-keys) rule. To try and reduce time spent doing stylistic tweaks, this has been removed. If it's valuable to specific projects, the project lead can add it to the project. Adds the following rules: - [array-callback-return](https://eslint.org/docs/rules/array-callback-return) - Enforces return statements in callbacks of array’s methods - [no-extra-label](https://eslint.org/docs/rules/no-extra-label) - Disallow unnecessary Labels (catches incorrectly formed objects) - [no-native-reassign](https://eslint.org/docs/rules/no-native-reassign) - Sets many (browser) globals as read-only - [no-restricted-syntax](https://eslint.org/docs/rules/no-restricted-syntax) - ['warn', 'WithStatement'] Disallows `with` - [no-restricted-globals](https://eslint.org/docs/rules/no-restricted-globals) - Disallow some globals (e.g. `'no-restricted-globals': ['error'].concat(restrictedGlobals),`). See https://github.com/facebook/create-react-app/blob/next/packages/confusing-browser-globals/index.js - [no-unused-labels](https://eslint.org/docs/rules/no-unused-labels) - Disallow unnecessary Labels (catches incorrectly formed objects) - [no-useless-concat](https://eslint.org/docs/rules/no-useless-concat) - Disallows concatenation of short (e.g. non-multiline) string literals - [radix](https://eslint.org/docs/rules/radix) - ensures radix is specified (when using `as-needed`) - [promise/no-new-statics](https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/no-new-statics.md) - avoids TypeErrors from calling `new` on a Promise static method
blakek
requested review from
stevengrimaldo,
dwevins,
meyer-mcmains and
clarkmcadoo
clarkmcadoo
approved these changes
Feb 2, 2020
| "eslint-plugin-node": "4 || 5", | ||
| "eslint-plugin-promise": "^3.5.0", | ||
| "eslint-plugin-standard": "^3.0.1" | ||
| "confusing-browser-globals": "^1.0.9", |
meyer-mcmains
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
withstatementsas-needed)newon a Promise static methodChanged
eslint-plugin-prettierto stop conflicts between ESLint and Prettier.Removed
Resolves #5