Allow timestamps of srt and vtt files with a 1-digit hour #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains change suggestion for the regular expressions that parse the timestamps of srt and vtt files. The goal is to handle also timestamps that have only one digit in the hour part. This change is related to the issue #31 .
Motivation for the change was that some programs that generate srt subtitle files use 1 to n digits in the hour part of the timestamp while subtitle.js originally expects 2 to n digits in the hour part of the timestamp. This resulted in malformed vtt files in the cases where 1-digit hour was present in the srt file's timestamp.
New unit tests for verifying the changes were added to the parseTImestamps.test.js file.