-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Open file at Line Number from Intent #1202
Comments
Also, whenever navigating from aGrep to Markor, it always ends up in a viewer. Obviously, this is because the intent is ACTION_VIEW, so there is no way to open the editor, unless there's a hack to open the editor if the line number is sent, or to remember the position when switching to the editor. The second option would depend on #1149 cause it doesn't seem to work at the moment. |
I may read the rest later but
starting with that attitude you usually not find somebody to waste his !!freetime!! with whatever you bid them for. Btw Markor has a decent simple & regex search - just not recursive. |
For most basic cases this is more than sufficient. Markor is on a good path to match the necessary functionality in this respect, with only the search missing. It is obvious that the search is likely the most useful thing in a knowledge base or a wiki, apart from adding the information. I'm not sure what is going to happen with the changes in Android, and limiting of the file access, though. This might have a crippling effect on combining different tools, as I do here. |
One more use-case: amake/orgro#34 |
from agrep: we have support for line number by search PR #1337 . |
General information
Description
Since it's 2021 and there is still no decent full-text-search solution, would you please at least accept the line number from aGrep's intent?
In the aGrep's Preferences, there is an option "Send Intent with the line number". Hopefully this would be enough to navigate to the line number in Markor editor, allowing quick navigation in long files.
The code that creates the Intent can be previewed here.
The navigation from a long-press is initiated here. There's a slight difference but it should not matter for the receiver. The parameter is still "line".
As a side note, I would debate the need to have the full-text-search integrated but you've already rejected that request multiple times so far. Even though I have to say I don't understand the reasoning. The current phones have multiple Gigabytes of RAM and storage. aGrep, at least in my case, returns the results pretty much instantaneously so I don't really see a reason not to have search from the current location in the file navigator.
So, at least I'd hope that we can navigate to the desired result from aGrep.
Thanks!
The text was updated successfully, but these errors were encountered: