Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mhchem (KaTeX extension) #1575

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

fgtham
Copy link
Contributor

@fgtham fgtham commented Feb 2, 2022

KaTeX provides the mhchem extension for typesetting chemical formulas. This PR adds the JS asset for KaTeX v011.1 and loads the file right after katex.min.js. I hope that's all there is to it :)

@gsantner
Copy link
Owner

gsantner commented Feb 2, 2022

Thx. I happily merge. However I don't use KaTex on my own.

There are some issues open about KaTex at Markor and nobody has stepped up to do something about it so far. As you seem to have some idea about it, it would be very cool if you can also check those? #1389 #1393

I see there are other KaTex extensions as well. Do you see any other of them as something you would use regular?

@fgtham
Copy link
Contributor Author

fgtham commented Feb 3, 2022

There are some issues open about KaTex at Markor and nobody has stepped up to do something about it so far. As you seem to have some idea about it, it would be very cool if you can also check those? #1389 #1393

Sure, I will have a look.

I see there are other KaTex extensions as well. Do you see any other of them as something you would use regular?

There seem to be two other extensions: Copy-tex and math/tex Custom Script Type. I am not familiar with either one.

@gsantner gsantner added this to the 2.9 milestone Feb 4, 2022
@gsantner gsantner merged commit 7b84c40 into gsantner:master Feb 4, 2022
@gsantner
Copy link
Owner

gsantner commented Feb 4, 2022

Thanks for your First-time contributon, merged

@fgtham fgtham deleted the mhchem_support branch February 6, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants