Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite newer files unless content modified #1758

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

harshad1
Copy link
Collaborator

Without this we have the following situation

  1. Open file (don't modify)
  2. File changed in background (syncthing etc)
  3. On close, the changed file is overwritten by the old content

This is a bug I introduced :(

@gsantner gsantner added this to the Markor v2.10 milestone Jul 12, 2022
@gsantner gsantner merged commit e17bafd into gsantner:master Jul 12, 2022
gsantner added a commit that referenced this pull request Jul 12, 2022
@gsantner gsantner mentioned this pull request Jul 16, 2022
jiesou pushed a commit to jiesou/markor that referenced this pull request Jul 20, 2022
@harshad1 harshad1 deleted the dont_overwrite_on_save branch May 10, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants